chore: Remove HTML column type feature flag and related code#39108
Conversation
rahulbarwal
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
rahulbarwal
requested review from
AmanAgarwal041,
jacquesikot and
sneha122
and removed request for
ApekshaBhosale and
sagar-qa007
rahulbarwal
added
Table Widget V2
WalkthroughThis PR removes the "release_table_html_column_type_enabled" feature flag from multiple code areas. The test setup no longer intercepts this flag, the feature flag definition and its default value are deleted, and the related constant is removed. TableWidgetV2’s legacy HTML column handling is eliminated with updated imports, memoization functions, and method signatures. Additionally, the column type configuration now always displays the HTML option without conditional visibility, and redundant configuration imports are removed. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant P as Property Panel
participant T as TableWidgetV2
U->>P: Open column type dropdown
P->>T: Request column configuration
T-->>P: Return type options including HTML
U->>P: Select HTML column
P->>T: Update column configuration
T-->>P: Render HTML cell without feature flag checks
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (6)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🔇 Additional comments (6)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13195819494. |
|
Deploy-Preview-URL: https://ce-39108.dp.appsmith.com |
rahulbarwal
deleted the
rahulbarwal/remove-htmlcell-flag-in-table-widget-v2
branch
…horg#39108) ## Description It has been a month since we have turned on the flag for table HTML column type and we have not seen any issues. This PR removes all the feature flags related code from the codebase. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13195811365> > Commit: 7a0f810 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13195811365&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Fri, 07 Feb 2025 09:20:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - The HTML column type now appears as a consistently available option when configuring table widgets. - **Refactor** - The table widget’s architecture has been streamlined for improved modularity and state management, enhancing overall cell rendering. - **Chore** - Legacy conditional toggling for the HTML column type has been removed to simplify configuration and standardize behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
Description
It has been a month since we have turned on the flag for table HTML column type and we have not seen any issues.
This PR removes all the feature flags related code from the codebase.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Table"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13195811365
Commit: 7a0f810
Cypress dashboard.
Tags:
@tag.TableSpec:
Fri, 07 Feb 2025 09:20:10 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Refactor
Chore